Hi KOSAKI,
On Mon, May 2, 2011 at 7:37 PM, KOSAKI Motohiro
<kosaki.motohiro@xxxxxxxxxxxxxx> wrote:
>> It's pointless that deactive_page's pagevec operation about
>> unevictable page as it's nop.
>> This patch removes unnecessary overhead which might be a bit problem
>> in case that there are many unevictable page in system(ex, mprotect workload)
>>
>> Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx>
>> ---
>> Âmm/swap.c | Â Â9 +++++++++
>> Â1 files changed, 9 insertions(+), 0 deletions(-)
>>
>> diff --git a/mm/swap.c b/mm/swap.c
>> index 2e9656d..b707694 100644
>> --- a/mm/swap.c
>> +++ b/mm/swap.c
>> @@ -511,6 +511,15 @@ static void drain_cpu_pagevecs(int cpu)
>> Â */
>> Âvoid deactivate_page(struct page *page)
>> Â{
>> +
>> + Â Â /*
>> + Â Â Â* In workload which system has many unevictable page(ex, mprotect),
>> + Â Â Â* unevictalge page deactivation for accelerating reclaim
>> + Â Â Â* is pointless.
>> + Â Â Â*/
>> + Â Â if (PageUnevictable(page))
>> + Â Â Â Â Â Â return;
>> +
>
> Â Â Â ÂReviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
>
Thanks!
>
> btw, I think we should check PageLRU too.
>
Yes. I remember you advised it when we push this patch but I didn't.
That's because I think most of pages in such context would be LRU as
they are cached pages.
So IMO, PageLRU checking in deactivate_page couldn't help much.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href