On Wed 10-07-19 11:42:40, Mike Kravetz wrote: [...] > As Michal suggested, I'm going to do some testing to see what impact > dropping the __GFP_RETRY_MAYFAIL flag for these huge page allocations > will have on the number of pages allocated. Just to clarify. I didn't mean to drop __GFP_RETRY_MAYFAIL from the allocation request. I meant to drop the special casing of the flag in should_continue_reclaim. I really have hard time to argue for this special casing TBH. The flag is meant to retry harder but that shouldn't be reduced to a single reclaim attempt because that alone doesn't really help much with the high order allocation. It is more about compaction to be retried harder. -- Michal Hocko SUSE Labs
