On Wed, May 22, 2019 at 11:19:16AM -0700, Andrew Morton wrote: > On Wed, 22 May 2019 17:09:39 +0200 "Uladzislau Rezki (Sony)" <urezki@xxxxxxxxx> wrote: > > > Move the BUG_ON()/RB_EMPTY_NODE() check under unlink_va() > > function, it means if an empty node gets freed it is a BUG > > thus is considered as faulty behaviour. > > So... this is an expansion of the assertion's coverage? > I would say it is rather moving BUG() and RB_EMPTY_NODE() check under unlink_va(). We used to have BUG_ON() and it is still there but now inlined. So it is not about assertion's coverage. -- Vlad Rezki