Re: [PATCH 4/4] mm/vmap: move BUG_ON() check to the unlink_va()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Uladzislau Rezki (Sony)" <urezki@xxxxxxxxx>
Subject: Re: [PATCH 4/4] mm/vmap: move BUG_ON() check to the unlink_va()
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 22 May 2019 11:19:16 -0700
Cc: Roman Gushchin <guro@xxxxxx>, Michal Hocko <mhocko@xxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, linux-mm@xxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Thomas Garnier <thgarnie@xxxxxxxxxx>, Oleksiy Avramchenko <oleksiy.avramchenko@xxxxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Joel Fernandes <joelaf@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>
In-reply-to: <20190522150939.24605-4-urezki@gmail.com>
References: <20190522150939.24605-1-urezki@gmail.com> <20190522150939.24605-4-urezki@gmail.com>

On Wed, 22 May 2019 17:09:39 +0200 "Uladzislau Rezki (Sony)" <urezki@xxxxxxxxx> wrote:

> Move the BUG_ON()/RB_EMPTY_NODE() check under unlink_va()
> function, it means if an empty node gets freed it is a BUG
> thus is considered as faulty behaviour.

So... this is an expansion of the assertion's coverage?

Follow-Ups:
- Re: [PATCH 4/4] mm/vmap: move BUG_ON() check to the unlink_va()
  - From: Uladzislau Rezki

References:
- [PATCH 1/4] mm/vmap: remove "node" argument
  - From: Uladzislau Rezki (Sony)
- [PATCH 4/4] mm/vmap: move BUG_ON() check to the unlink_va()
  - From: Uladzislau Rezki (Sony)

Prev by Date: Re: [PATCH 3/4] mm/vmap: get rid of one single unlink_va() when merge
Next by Date: Re: [PATCH] mm/gup: continue VM_FAULT_RETRY processing event for pre-faults
Previous by thread: [PATCH 4/4] mm/vmap: move BUG_ON() check to the unlink_va()
Next by thread: Re: [PATCH 4/4] mm/vmap: move BUG_ON() check to the unlink_va()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]