On 4/11/19 11:22 AM, Michal Hocko wrote:
> On Thu 11-04-19 09:52:45, Mike Kravetz wrote:
>> Or, do you think that is too much?
>> Ideally, that comment should have been added as part of 58b6e5e8f1ad
>> ("hugetlbfs: fix memory leak for resv_map") as it could cause one to wonder
>> if resv_map could be NULL.
>
> I would much rather explain a comment explaining _when_ inode_resv_map
> might return NULL than add checks just to be sure.
You are right. That would make more sense. It has been a while since I
looked into that code and unfortunately I did not save notes. I'll do some
research to come up with an appropriate explanation/comment.
--
Mike Kravetz
