RE: [PATCH] mm/gup.c: fix the wrong comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > On Apr 4, 2019, at 1:23 AM, Huang Shijie <sjhuang@xxxxxxxxxxx> wrote:
> >
> >
> > + * This function is different from the get_user_pages_unlocked():
> > + *      The @pages may has different page order with the result
> > + *      got by get_user_pages_unlocked().
> > + *
> 
> I suggest a slight rewrite of the comment, something like:
> 
> * Note this routine may fill the pages array with entries in a
> * different order than get_user_pages_unlocked(), which may cause
> * issues for callers expecting the routines to be equivalent.

This is good too.  :-D

Ira





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux