On Thu, Apr 04, 2019 at 06:33:09PM +0530, Anshuman Khandual wrote: > Sure. Will remove them from the proposed functions next time around. Just need to make sure that the function is not calling directly or indirectly another __meminit function, then it is safe to remove it. E.g: sparse_add_one_section() is wrapped around CONFIG_MEMORY_HOTPLUG, but the __meminit must stay because it calls sparse_index_init(), sparse_init_one_section() and sparse_mem_map_populate(), all three marked as __meminit because they are also used out of hotplug scope, during early boot. -- Oscar Salvador SUSE L3
