On Fri, Mar 29, 2019 at 10:13:25AM +0100, Michal Hocko wrote: > On Fri 29-03-19 16:29:15, Baoquan He wrote: > > The input parameter 'phys_index' of memory_block_action() is actually > > the section number, but not the phys_index of memory_block. Fix it. > > I have tried to explain that the naming is mostly a relict from the past > than really a misleading name http://lkml.kernel.org/r/20190326093315.GL28406@xxxxxxxxxxxxxx > Maybe it would be good to reflect that in the changelog I think that phys_device variable in remove_memory_section() is also a relict from the past, and it is no longer used. Neither node_id variable is used. Actually, unregister_memory_section() sets those two to 0 no matter what. Since we are cleaning up, I wonder if we can go a bit further and we can get rid of that as well. -- Oscar Salvador SUSE L3
