On Thu, Apr 14, 2011 at 9:41 AM, David Rientjes <rientjes@xxxxxxxxxx> wrote: > There's a kernel-wide shortage of per-process flags, so it's always > helpful to trim one when possible without incurring a significant > penalty. ÂIt's even more important when you're planning on adding a per- > process flag yourself, which I plan to do shortly for transparent > hugepages. > > PF_OOM_ORIGIN is used by ksm and swapoff to prefer current since it has a > tendency to allocate large amounts of memory and should be preferred for > killing over other tasks. ÂWe'd rather immediately kill the task making > the errant syscall rather than penalizing an innocent task. > > This patch removes PF_OOM_ORIGIN since its behavior is equivalent to > setting the process's oom_score_adj to OOM_SCORE_ADJ_MAX. > > The process's old oom_score_adj is stored and then set to > OOM_SCORE_ADJ_MAX during the time it used to have PF_OOM_ORIGIN. ÂThe old > value is then reinstated when the process should no longer be considered > a high priority for oom killing. > > Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx> Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx> Seem to be reasonable and code don't have a problem. But couldn't we make the function in general(ex, passed task_struct) and use it when we change oom_score_adj(ex, oom_score_adj_write)? -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href