On Fri, 2011-04-08 at 22:54 +0200, MichaÅ Nazarewicz wrote: > On Apr 8, 2011 10:23 PM, "Dave Hansen" <dave@xxxxxxxxxxxxxxxxxx> wrote: > > + if (fmt) { > > + printk(KERN_WARNING); > > + va_start(args, fmt); > > + r = vprintk(fmt, args); > > + va_end(args); > > + } > > Could we make the "printk(KERN_WARNING);" go away and require caller > to specify level? The core problem is this: I want two lines of output: one for the order/mode gunk, and one for the user-specified message. If we have the user pass in a string for the printk() level, we're stuck doing what I have here. If we have them _prepend_ it to the "fmt" string, then it's harder to figure out below. I guess we could fish in the string for it. > > + printk(KERN_WARNING); > > + printk("%s: page allocation failure: order:%d, mode:0x%x\n", > > + current->comm, order, gfp_mask); > > Even more so here. Why not pr_warning instead of two non-atomic calls > to printk? It's a relic of an hour ago when I tried passing in the printk() level to the function as a string. It can go away now. :) -- Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>