Re: [PATCH 1/2] break out page allocation warning code

[MichaÅ Nazarewicz <mnazarewicz@xxxxxxxxx>]

On Apr 8, 2011 10:23 PM, "Dave Hansen" <dave@xxxxxxxxxxxxxxxxxx> wrote:
> + Â Â Â if (fmt) {
> + Â Â Â Â Â Â Â printk(KERN_WARNING);
> + Â Â Â Â Â Â Â va_start(args, fmt);
> + Â Â Â Â Â Â Â r = vprintk(fmt, args);
> + Â Â Â Â Â Â Â va_end(args);
> + Â Â Â }

Could we make the "printk(KERN_WARNING);" go away and require caller to specify level?Â

> + Â Â Â printk(KERN_WARNING);
> + Â Â Â printk("%s: page allocation failure: order:%d, mode:0x%x\n",
> + Â Â Â Â Â Â Â Â Â Â Â current->comm, order, gfp_mask);

Even more so here. Why not pr_warning instead of two non-atomic calls to printk?