Hi! > > Your patch 3/3 just removes the test. Am I right in thinking that it > > doesn't need to be *moved* because the existing test after !PageUptodate > > catches it? > > Exactly. It just initiates read-ahead for IOCB_NOWAIT cases as well, and > if it's actually set, it'll be handled by the !PageUpdtodate case. > > > Of course, there aren't any tests for RWF_NOWAIT in xfstests. Are there > > any in LTP? > > Not in the released version AFAIK. I've asked the LTP maintainer (in our > internal bugzilla) to take care of this thread a few days ago, but not > sure what came out of it. Adding him (Cyril) to CC. So far not much, I've looked over our mincore() tests and noted down how to improve them here: https://github.com/linux-test-project/ltp/issues/461 We do plan to test the final mincore() fix: https://github.com/linux-test-project/ltp/issues/460 And we do have RWF_NOWAIT tests on our TODO for some time as well: https://github.com/linux-test-project/ltp/issues/286 I guess I can raise priority for that one so that we have basic functional tests in a week or so. Also if anyone has some RWF_NOWAIT tests already it would be nice if these could be shared with us. [A bit off topic rant] I've been telling kernel developers for years that if they have a test code they used when developing a kernel feature that they should share it with us (LTP community) and we will turn these into automated tests and maintain them for free. LTP is also used in many QA departements around the word so such tests will end up executed in different environments also for free. Sadly this does not happen much and there are only few exceptions so far. But maybe I wasn't shouting loudly enough. -- Cyril Hrubis chrubis@xxxxxxx
