> On Jan 16, 2019, at 6:07 PM, Jane Chu <jane.chu@xxxxxxxxxx> wrote: > > It's just coding style I'm used to, no big deal. > Up to you to decide. :) Personally I like a (void) cast as it's pretty long-standing syntactic sugar to cast a call that returns a value we don't care about to (void) to show we know it returns a value and we don't care. Without it, it may suggest we either didn't know it returned a value or that we neglected to check the return value. However, in current use elsewhere (e.g. in send_sig_all() and __oom_kill_process()), no such (void) cast is added, so it seems better to match current usage elsewhere in the kernel. Reviewed-by: William Kucharski <william.kucharski@xxxxxxxxxx>
