On Mon, Dec 17, 2018 at 9:38 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Mon, 17 Dec 2018 20:33:42 +0100 Andrey Konovalov <andreyknvl@xxxxxxxxxx> wrote: > > > > Curiosity, did you try your patches with SLUB red zoning enabled? > > > Since the area used for the Redzone is just after the payload, aligning the > > > object_size independently from the allocator could have side effects, at least > > > if I understand well how the mechanism works. > > > > > > Setting ARCH_SLAB_MINALIGN should avoid this as well. > > > > > > What do you think? > > > > Sounds good to me. > > > > Andrew, how should proceed with this? Send another fixup patch or > > resend the whole series? > > It depends on how extensive the changes are. I prefer a fixup, but at > some point it's time to drop it all and start again. The fixup in only a few lines, so I just sent it as a separate patch named "[PATCH mm] kasan, arm64: use ARCH_SLAB_MINALIGN instead of manual aligning". Thanks!
