On Mon, Nov 26, 2018 at 09:16:08AM +0100, Michal Hocko wrote: >On Mon 26-11-18 10:28:40, Wei Yang wrote: >[...] >> But I get some difficulty to understand this TODO. You want to get rid of >> these lock? While these locks seem necessary to protect those data of >> pgdat/zone. Would you mind sharing more on this statement? > >Why do we need this lock to be irqsave? Is there any caller that uses >the lock from the IRQ context? I see you put the comment 'irqsave' in code, I thought this is the requirement bringing in by this commit. So this is copyed from somewhere else? >From my understanding, we don't access pgdat from interrupt context. BTW, one more confirmation. One irqsave lock means we can't do something during holding the lock, like sleep. Is my understanding correct? >-- >Michal Hocko >SUSE Labs -- Wei Yang Help you, Help me