Re: [RFC] put page to pcp->lists[] tail if it is not on the same node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 19, 2018 at 04:33:03AM +0000, Wei Yang wrote:
> node
> Reply-To: Wei Yang <richard.weiyang@xxxxxxxxx>
> 
> Masters,
> 
> During the code reading, I pop up this idea.
> 
>     In case we put some intelegence of NUMA node to pcp->lists[], we may
>     get a better performance.
> 

Why?

> The idea is simple:
> 
>     Put page on other nodes to the tail of pcp->lists[], because we
>     allocate from head and free from tail.
> 

Pages from remote nodes are not placed on local lists. Even in the slab
context, such objects are placed on alien caches which have special
handling.

> Since my desktop just has one numa node, I couldn't test the effect.

I suspect it would eventually cause a crash or at least weirdness as the
page zone ids would not match due to different nodes.

> Sorry for sending this without a real justification. Hope this will not
> make you uncomfortable. I would be very glad if you suggest some
> verifications that I could do.
> 
> Below is my testing patch, look forward your comments.
> 

I commend you trying to understand how the page allocator works but I
suggest you take a step back, pick a workload that is of interest and
profile it to see where hot spots are that may pinpoint where an
improvement can be made.

-- 
Mel Gorman
SUSE Labs




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux