Re: [PATCH] mm/sparse: remove a check that compare if unsigned variable is negative

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Pavel Tatashin <pasha.tatashin@xxxxxxxxx>
Subject: Re: [PATCH] mm/sparse: remove a check that compare if unsigned variable is negative
From: Wei Yang <richard.weiyang@xxxxxxxxx>
Date: Fri, 19 Oct 2018 08:28:01 +0000
Cc: penghao122@xxxxxxxxxxx, Linux Memory Management List <linux-mm@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, pasha.tatashin@xxxxxxxxxx, osalvador@xxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, peng.hao2@xxxxxxxxxx
In-reply-to: <CAGM2reYqEpY9KbMDU6uSaCuzsyN6qcXit930vbWk54PLhvZxZg@mail.gmail.com>
References: <1539447319-5383-1-git-send-email-penghao122@sina.com.cn> <CAGM2reYqEpY9KbMDU6uSaCuzsyN6qcXit930vbWk54PLhvZxZg@mail.gmail.com>
Reply-to: Wei Yang <richard.weiyang@xxxxxxxxx>
User-agent: NeoMutt/20170113 (1.7.2)

On Sat, Oct 13, 2018 at 01:04:45PM -0400, Pavel Tatashin wrote:
>This is incorrect: next_present_section_nr() returns "int" and -1 no
>next section, this change would lead to infinite loop.

Yes, the -1 is a very special value.

-- 
Wei Yang
Help you, Help me

References:
- Re: [PATCH] mm/sparse: remove a check that compare if unsigned variable is negative
  - From: Pavel Tatashin

Prev by Date: Re: [PATCH] memblock: remove stale #else and the code it protects
Next by Date: Re: [RFC] put page to pcp->lists[] tail if it is not on the same node
Previous by thread: Re: [PATCH] mm/sparse: remove a check that compare if unsignedvariable is negative
Next by thread: Re: + memblock-warn-if-zero-alignment-was-requested.patch added to -mm tree
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux