On Wed, Oct 10, 2018 at 6:13 PM Darrick J. Wong <darrick.wong@xxxxxxxxxx> wrote: > > On Wed, Oct 10, 2018 at 08:54:44AM +0300, Amir Goldstein wrote: > > On Wed, Oct 10, 2018 at 3:12 AM Darrick J. Wong <darrick.wong@xxxxxxxxxx> wrote: > > > > > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > > > Combine the clone_file_range and dedupe_file_range operations into a > > > single remap_file_range file operation dispatch since they're > > > fundamentally the same operation. The differences between the two can > > > be made in the prep functions. > > > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > --- > > > > > > Apart from the generic check invalid flags comment - ACK on ovl part. > > Thanks for the review! Is that an official Acked-by to add to the > commit message, or an informal ACK? > I would offer my Acked-by for whole of the vfs patches if we agree on the correct way to handle invalid flags (see more comments up the series regarding the "advisory" flags). Thanks, Amir.
