On Wed, Oct 10, 2018 at 05:13:20PM +0300, Kirill A. Shutemov wrote: >On Wed, Oct 10, 2018 at 08:53:27PM +0800, Wei Yang wrote: >> A non-NULL vma returned from find_vma() implies: >> >> vma->vm_start <= start >> Since len != 0, the following condition always hods: > >s/hods/holds/ > >> vma->vm_start < start + len = end >> >> This means the if check would never be true. > >Have you considered overflow? > Thanks for your comment. At the beginning of this function, we make sure (len <= TASK_SIZE - start). -- Wei Yang Help you, Help me
