> Where's your signed-off-by? Somewhere under the pile of crap on my desk. :-) (More to the point, waiting for me to think it's good enough to submit For Real.) > Nice cleanup. > > "flag" should be unsigned long in all of these functions: the constants > are declared with UL suffixes in slab.h. Actually, I did that deliberately. Because there's a problem I keep wondering about, which repeats many many times in the kernel: *Why* are they unsigned long? That's an awkward type: 32 bits on many architectures, so we can't portably assign more than 32 bits, and on platforms where it's 64 bits, the upper 32 are just wasting space. (And REX prefixes on x86-64.) Wouldn't it be a better cleanup to convert the whole lot to unsigned or u32? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>