On Mon 10-09-18 22:03:17, zhong jiang wrote: > The if condition can be removed if we use BUG_ON directly. > The issule is detected with the help of Coccinelle. typo here Is this really worth changing? If anything I would really love to see the BUG_ON going away rather than make a cosmetic changes to it. > Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx> > --- > mm/memory_hotplug.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 38d94b7..280b26c 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1888,8 +1888,7 @@ void __ref remove_memory(int nid, u64 start, u64 size) > */ > ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL, > check_memblock_offlined_cb); > - if (ret) > - BUG(); > + BUG(ret); > > /* remove memmap entry */ > firmware_map_remove(start, start + size, "System RAM"); > -- > 1.7.12.4 > -- Michal Hocko SUSE Labs
