The if condition can be removed if we use BUG_ON directly. The issule is detected with the help of Coccinelle. Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx> --- mm/memory_hotplug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 38d94b7..280b26c 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1888,8 +1888,7 @@ void __ref remove_memory(int nid, u64 start, u64 size) */ ret = walk_memory_range(PFN_DOWN(start), PFN_UP(start + size - 1), NULL, check_memblock_offlined_cb); - if (ret) - BUG(); + BUG(ret); /* remove memmap entry */ firmware_map_remove(start, start + size, "System RAM"); -- 1.7.12.4
