Re: [PATCH v2 2/3] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Hildenbrand <david@xxxxxxxxxx>
Subject: Re: [PATCH v2 2/3] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes
From: Oscar Salvador <osalvador@xxxxxxxxxxxxxxxxxx>
Date: Tue, 14 Aug 2018 14:36:10 +0200
Cc: akpm@xxxxxxxxxxxxxxxxxxxx, mhocko@xxxxxxxx, dan.j.williams@xxxxxxxxx, jglisse@xxxxxxxxxx, rafael@xxxxxxxxxx, yasu.isimatu@xxxxxxxxx, logang@xxxxxxxxxxxx, dave.jiang@xxxxxxxxx, Jonathan.Cameron@xxxxxxxxxx, vbabka@xxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Oscar Salvador <osalvador@xxxxxxx>
In-reply-to: <292e9b31-b043-d140-77da-03082025fa1b@redhat.com>
References: <20180813154639.19454-1-osalvador@techadventures.net> <20180813154639.19454-3-osalvador@techadventures.net> <82148bc6-672d-6610-757f-d910a17d23c6@redhat.com> <20180814093652.GA6878@techadventures.net> <39454952-f8c9-4ded-acb5-02192e889de0@redhat.com> <20180814100644.GB6979@techadventures.net> <292e9b31-b043-d140-77da-03082025fa1b@redhat.com>
User-agent: Mutt/1.5.23 (2014-03-12)

On Tue, Aug 14, 2018 at 12:09:14PM +0200, David Hildenbrand wrote:
> 
> Whatever you think is best. I have no idea what the general rules in MM
> code are. Maybe dropping this check is totally fine.

Well, if you ask me, callers should care for validating mem_blk before calling in.
But a WARN_ON is not harmful either.

Let us just wait to hear more from others.

Thanks
-- 
Oscar Salvador
SUSE L3

References:
- [PATCH v2 0/3] Refactoring for remove_memory_section/unregister_mem_sect_under_nodes
  - From: osalvador
- [PATCH v2 2/3] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes
  - From: osalvador
- Re: [PATCH v2 2/3] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes
  - From: David Hildenbrand
- Re: [PATCH v2 2/3] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes
  - From: Oscar Salvador
- Re: [PATCH v2 2/3] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes
  - From: David Hildenbrand
- Re: [PATCH v2 2/3] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes
  - From: Oscar Salvador
- Re: [PATCH v2 2/3] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes
  - From: David Hildenbrand

Prev by Date: Re: [PATCH RFC] usercopy: optimize stack check flow when the
Next by Date: RE: [PATCH RFC] usercopy: optimize stack check flow when the page-spanning test is disabled
Previous by thread: Re: [PATCH v2 2/3] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes
Next by thread: [PATCH v2 3/3] mm/memory_hotplug: Refactor unregister_mem_sect_under_nodes
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]