On 08/03/2018 12:01 PM, Andy Shevchenko wrote: > On Fri, Aug 3, 2018 at 6:59 PM, Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: >> On Fri, Aug 3, 2018 at 6:17 PM, Tony Battersby <tonyb@xxxxxxxxxxxxxxx> wrote: >>> But then I decided to simplify it to just use dev_err(). I still have >>> the old version. When I submit v3 of the patchset, which would you prefer? >> JFYI: git log --no-merges --grep 'NULL device \*' > Example: > > commit b4ba97e76763c4e582e3af1079e220e93b1b0d76 > Author: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Date: Fri Aug 19 08:37:50 2016 +0100 > > drm: Avoid calling dev_printk(.dev = NULL) > Point taken. I'll go with pool_err() on the next round.