On Thu, Aug 2, 2018 at 10:57 PM, Tony Battersby <tonyb@xxxxxxxxxxxxxxx> wrote: > Remove code duplication in error messages. It is now safe to pas a NULL > dev to dev_err(), so the checks to avoid doing so are no longer > necessary. > > Example: > > Error message with dev != NULL: > mpt3sas 0000:02:00.0: dma_pool_destroy chain pool, (____ptrval____) busy > > Same error message with dev == NULL before patch: > dma_pool_destroy chain pool, (____ptrval____) busy > > Same error message with dev == NULL after patch: > (NULL device *): dma_pool_destroy chain pool, (____ptrval____) busy Have you checked a history of this? I'm pretty sure this was created in an order to avoid bad looking (and in some cases frightening) "NULL device *" part. If it it's the case, I would rather leave it as is, and even not the case, I'm slightly more bent to the current state. -- With Best Regards, Andy Shevchenko
