On Wed, 9 Mar 2011, Andrew Morton wrote: > If Oleg's test program cause a hang with > oom-prevent-unnecessary-oom-kills-or-kernel-panics.patch and doesn't > cause a hang without > oom-prevent-unnecessary-oom-kills-or-kernel-panics.patch then that's a > big problem for > oom-prevent-unnecessary-oom-kills-or-kernel-panics.patch, no? > It's a problem, but not because of oom-prevent-unnecessary-oom-kills-or-kernel-panics.patch. If we don't have this patch, then we have a trivial panic when an oom kill occurs in a cpuset with no other eligible processes, the oom killed thread group leader exits but its other threads do not and they trigger oom kills themselves. for_each_process() does not iterate over these threads and so it finds no eligible threads to kill and then panics (and we have many examples of that happening in production). I'll look at Oleg's test case and see what can be done to fix that condition, but the answer isn't to ignore eligible threads that can be killed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>