On Mon, Jul 23, 2018 at 10:35:19AM +0200, Michal Hocko wrote: > No, I do not think this is much better. Why do we need to separate those > functions out? I think you are too focused on the current function > without a broader context. Think about it. We have two code paths. > Early initialization and the hotplug. The two are subtly different in > some aspects. Maybe reusing free_area_init_core is the wrong thing and > we should have a dedicated subset of this function. This would make the > code more clear probably. You wouldn't have to think which part of > free_area_init_core is special and what has to be done if this function > was to be used in a different context. See my point? Yes, I see your point now. I will think about it with a wider approach. Thanks -- Oscar Salvador SUSE L3
