On Fri, Jul 20, 2018 at 03:57:47PM -0400, Jerome Glisse wrote: > On Fri, Jul 20, 2018 at 12:51:46PM -0700, Andrew Morton wrote: > > Problem is, that patch is eighth in a series which we're waiting for > > Jerome to review and the changelog starts with "Now that all producers > > of dev_pagemap instances in the kernel are properly converted to > > EXPORT_SYMBOL_GPL...". > > I am fine with the patchset modulo GPL, i did review it in the past > but i did not formaly reply as i was opose to the GPL changes. So my > only objection is with the GPL export, everything else looks fine. Everyone from the mm side who's looked at these patches agrees that it reaches far too far into the guts of the mm to be anything other than exposing internals. It's not credible to claim that a module written that uses these interfaces is anything other than a derived work of the kernel. I feel these patches should be merged over Jerome's objections.
