On Fri, 20 Jul 2018 14:43:14 +0000 Mark Vitale <mvitale@xxxxxxxxxxxxxx> wrote: > On Jul 11, 2018, Dan Williams wrote: > > Changes since v3 [1]: > > * Collect Logan's reviewed-by on patch 3 > > * Collect John's and Joe's tested-by on patch 8 > > * Update the changelog for patch 1 and 7 to better explain the > > EXPORT_SYMBOL_GPL rationale. > > * Update the changelog for patch 2 to clarify that it is a cleanup to > > make the following patch-3 fix easier > > > > [1]: https://lkml.org/lkml/2018/6/19/108 > > > > --- > > > > Hi Andrew, > > > > As requested, here is a resend of the devm_memremap_pages() fixups. > > Please consider for 4.18. > > What is the status of this patchset? OpenAFS is unable to build on > Linux 4.18 without the last patch in this set: > > 8/8 mm: Fix exports that inadvertently make put_page() EXPORT_SYMBOL_GPL > > Will this be merged soon to linux-next, and ultimately to a Linux 4.18 rc? > Problem is, that patch is eighth in a series which we're waiting for Jerome to review and the changelog starts with "Now that all producers of dev_pagemap instances in the kernel are properly converted to EXPORT_SYMBOL_GPL...". Is it in fact a standalone patch? Not sure. I'll see what the build system has to say about that. And it will need a new changelog. Such as From: Dan Williams <dan.j.williams@xxxxxxxxx> Subject: mm: fix exports that inadvertently make put_page() EXPORT_SYMBOL_GPL e76384884344 ("mm: introduce MEMORY_DEVICE_FS_DAX and CONFIG_DEV_PAGEMAP_OPS") added two EXPORT_SYMBOL_GPL() symbols, but these symbols are required by the inlined put_page(), thus accidentally making put_page() a GPL export only. This breaks OpenAFS (at least). Mark them EXPORT_SYMBOL() instead. Link: http://lkml.kernel.org/r/153128611970.2928.11310692420711601254.stgit@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx Fixes: e76384884344 ("mm: introduce MEMORY_DEVICE_FS_DAX and CONFIG_DEV_PAGEMAP_OPS") Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx> Reported-by: Joe Gorse <jhgorse@xxxxxxxxx> Reported-by: John Hubbard <jhubbard@xxxxxxxxxx> Tested-by: Joe Gorse <jhgorse@xxxxxxxxx> Tested-by: John Hubbard <jhubbard@xxxxxxxxxx> Cc: Jérôme Glisse <jglisse@xxxxxxxxxx> Cc: Mark Vitale <mvitale@xxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- kernel/memremap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN kernel/memremap.c~mm-fix-exports-that-inadvertently-make-put_page-export_symbol_gpl kernel/memremap.c --- a/kernel/memremap.c~mm-fix-exports-that-inadvertently-make-put_page-export_symbol_gpl +++ a/kernel/memremap.c @@ -321,7 +321,7 @@ EXPORT_SYMBOL_GPL(get_dev_pagemap); #ifdef CONFIG_DEV_PAGEMAP_OPS DEFINE_STATIC_KEY_FALSE(devmap_managed_key); -EXPORT_SYMBOL_GPL(devmap_managed_key); +EXPORT_SYMBOL(devmap_managed_key); static atomic_t devmap_enable; /* @@ -362,5 +362,5 @@ void __put_devmap_managed_page(struct pa } else if (!count) __put_page(page); } -EXPORT_SYMBOL_GPL(__put_devmap_managed_page); +EXPORT_SYMBOL(__put_devmap_managed_page); #endif /* CONFIG_DEV_PAGEMAP_OPS */ _
