On Mon, 7 Mar 2011, Andrew Morton wrote: > Andrew's v2 doesn't apply on top of > oom-prevent-unnecessary-oom-kills-or-kernel-panics.patch and I'm > disinclined to fix that up and merge some untested patch combination. > Ok. Andrey, I rebased your patch on top of the latest -mm tree (mmotm-2011-03-02-16-52 with oom-prevent-unnecessary-oom-kills-or-kernel-panics.patch from http://marc.info/?l=linux-mm-commits&m=129953480527038&q=raw) and rewrote the changelog. They'll both apply on top of Linus' -git even without mmotm. Could you try this out on your testcase? Thanks! oom: skip zombies when iterating tasklist From: Andrey Vagin <avagin@xxxxxxxxxx> We shouldn't defer oom killing if a thread has already detached its ->mm and still has TIF_MEMDIE set. Memory needs to be freed, so find kill other threads that pin the same ->mm or find another task to kill. Signed-off-by: Andrey Vagin <avagin@xxxxxxxxxx> Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx> --- mm/oom_kill.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -299,6 +299,8 @@ static struct task_struct *select_bad_process(unsigned int *ppoints, do_each_thread(g, p) { unsigned int points; + if (!p->mm) + continue; if (oom_unkillable_task(p, mem, nodemask)) continue; @@ -324,7 +326,7 @@ static struct task_struct *select_bad_process(unsigned int *ppoints, * the process of exiting and releasing its resources. * Otherwise we could get an easy OOM deadlock. */ - if ((p->flags & PF_EXITING) && p->mm) { + if (p->flags & PF_EXITING) { if (p != current) return ERR_PTR(-1UL); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>