> scan_swap_map is a large function (224 lines), with several loops and a > complex control flow involving several gotos. > > Given all that, it is a bit silly that is is marked as inline. The > compiler agrees with me: on a x86-64 compile, it did not inline the > function. > > Remove the "inline" and let the compiler decide instead. > > Signed-off-by: Cesar Eduardo Barros <cesarb@xxxxxxxxxx> > --- > mm/swapfile.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 0341c57..8ed42e7 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -212,8 +212,8 @@ static int wait_for_discard(void *word) > #define SWAPFILE_CLUSTER 256 > #define LATENCY_LIMIT 256 > > -static inline unsigned long scan_swap_map(struct swap_info_struct *si, > - unsigned char usage) > +static unsigned long scan_swap_map(struct swap_info_struct *si, > + unsigned char usage) I agree. Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>