> On Sat, 5 Mar 2011, Andrey Vagin wrote: > > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > > index 7dcca55..2fc554e 100644 > > --- a/mm/oom_kill.c > > +++ b/mm/oom_kill.c > > @@ -311,7 +311,7 @@ static struct task_struct *select_bad_process(unsigned int *ppoints, > > * blocked waiting for another task which itself is waiting > > * for memory. Is there a better alternative? > > */ > > - if (test_tsk_thread_flag(p, TIF_MEMDIE)) > > + if (test_tsk_thread_flag(p, TIF_MEMDIE) && p->mm) > > return ERR_PTR(-1UL); > > > > /* > > I think it would be better to just do > > if (!p->mm) > continue; > > after the check for oom_unkillable_task() because everything that follows > this really depends on p->mm being non-NULL to actually do anything > useful. I'm glad you join to review MM patches. It is worth effort for making solid kernel. But, please look at a current code at first. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>