On Sat, 5 Mar 2011, Cesar Eduardo Barros wrote: > There is no reason I can see to read inode->i_size long before it is > needed. Move its read to just before it is needed, to reduce the > variable lifetime. > > Signed-off-by: Cesar Eduardo Barros <cesarb@xxxxxxxxxx> > Tested-by: Eric B Munson <emunson@xxxxxxxxx> > Acked-by: Eric B Munson <emunson@xxxxxxxxx> This will save us having to do the assignment in many cases where we jump to one of the labels at the end uf the function before using the 'swapfilepages' variable. Looks good to me. Reviewed-by: Jesper Juhl <jj@xxxxxxxxxxxxx> -- Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/ Plain text mails only, please. Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>