Re: [PATCH 10/10] mm: Prevent munmap and remap_file_pages of shadow stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andy Lutomirski <luto@xxxxxxxxxx>
Subject: Re: [PATCH 10/10] mm: Prevent munmap and remap_file_pages of shadow stack
From: Yu-cheng Yu <yu-cheng.yu@xxxxxxxxx>
Date: Thu, 07 Jun 2018 13:15:01 -0700
Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, Linux-MM <linux-mm@xxxxxxxxx>, linux-arch <linux-arch@xxxxxxxxxxxxxxx>, X86 ML <x86@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, "H. J. Lu" <hjl.tools@xxxxxxxxx>, "Shanbhogue, Vedvyas" <vedvyas.shanbhogue@xxxxxxxxx>, "Ravi V. Shankar" <ravi.v.shankar@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, mike.kravetz@xxxxxxxxxx
In-reply-to: <CALCETrXTyXYCDJxbCA+cbzZirmMKRQq8XSS4+Lyeo_QMywdxFw@mail.gmail.com>
References: <20180607143807.3611-1-yu-cheng.yu@intel.com> <20180607143807.3611-11-yu-cheng.yu@intel.com> <CALCETrXTyXYCDJxbCA+cbzZirmMKRQq8XSS4+Lyeo_QMywdxFw@mail.gmail.com>

On Thu, 2018-06-07 at 11:50 -0700, Andy Lutomirski wrote:
> On Thu, Jun 7, 2018 at 7:41 AM Yu-cheng Yu <yu-cheng.yu@xxxxxxxxx> wrote:
> 
> blocking remap_file_pages() seems reasonable.  I'm not sure what's
> wrong with munmap().

Yes, maybe we don't need to block munmap().  If the shadow stack is
unmapped, the application gets a fault.  I will remove the patch.

References:
- [PATCH 00/10] Control Flow Enforcement - Part (3)
  - From: Yu-cheng Yu
- [PATCH 10/10] mm: Prevent munmap and remap_file_pages of shadow stack
  - From: Yu-cheng Yu
- Re: [PATCH 10/10] mm: Prevent munmap and remap_file_pages of shadow stack
  - From: Andy Lutomirski

Prev by Date: Re: [PATCH 03/10] x86/cet: Signal handling for shadow stack
Next by Date: Re: [PATCH 03/10] x86/cet: Signal handling for shadow stack
Previous by thread: Re: [PATCH 10/10] mm: Prevent munmap and remap_file_pages of shadow stack
Next by thread: Re: [PATCH 00/10] Control Flow Enforcement - Part (3)
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]