On 30 May 2018 at 20:01, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > On Wed, May 30, 2018 at 07:28:43PM +0800, Baolin Wang wrote: >> It will be crash if we pass one NULL name when creating one dma pool, >> so we should check the passing name when copy it to dma pool. > > NAK. Crashing is the appropriate thing to do. Fix the caller to not > pass NULL. > > If you permit NULL to be passed then you're inviting crashes or just > bad reporting later when pool->name is printed. I think it just prints one NULL pool name. Sometimes the device doesn't care the dma pool names, so I think we can make code more solid to valid the passing parameters like other code does. Or can we add check to return NULL when the passing name is NULL instead of crashing the kernel? Thanks. -- Baolin.wang Best Regards
