On Mon, May 21, 2018 at 03:11:39AM -0700, Matthew Wilcox wrote: > On Sun, May 20, 2018 at 10:42:36PM -0600, Ross Zwisler wrote: > > > @@ -1519,15 +1517,14 @@ int dax_iomap_fault(struct vm_fault *vmf, enum page_entry_size pe_size, > > > } > > > EXPORT_SYMBOL_GPL(dax_iomap_fault); > > > > > > -/** > > > +/* > > > > Let's leave the double ** so that the function is picked up properly by > > the documentation system, and so it's consistent with the rest of the > > functions. > > This function is static. I think it's worth keeping the documentation, > but making it part of the exported kernel API documentation is confusing. Ah, fair enough. > By the way, nothing at all in fs/dax.c is picked up by the documentation > system today. We should probably fix that ... did you want to look at it > or shall I propose a patch to anchor it somewhere? If you have time for it that would be awesome.
