On 02/25, Linus Torvalds wrote: > > On Fri, Feb 25, 2011 at 9:52 AM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote: > > No functional changes, preparation to simplify the review. > > I think this is wrong. > > If you introduce the "bool compat" thing, you should also change the > type of the argument pointers to some opaque type at the same time. > It's no longer really a > > const char __user *const __user * > > pointer at that point. Trying to claim it is, is just wrong. The type > suddently becomes conditional on that 'compat' variable. Yes, this is true. And I agree this could be done in more clean way, just we need more changed. Please see the next email. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>