Re: [PATCH v12 00/11] Application Data Integrity feature introduced by SPARC M7

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Miller <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH v12 00/11] Application Data Integrity feature introduced by SPARC M7
From: Khalid Aziz <khalid.aziz@xxxxxxxxxx>
Date: Mon, 19 Mar 2018 09:19:21 -0600
Cc: dave.hansen@xxxxxxxxxxxxxxx, aarcange@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, allen.pais@xxxxxxxxxx, aneesh.kumar@xxxxxxxxxxxxxxxxxx, anthony.yznaga@xxxxxxxxxx, arnd@xxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, bob.picco@xxxxxxxxxx, bsingharora@xxxxxxxxx, corbet@xxxxxxx, dan.j.williams@xxxxxxxxx, dave.jiang@xxxxxxxxx, david.j.aldridge@xxxxxxxxxx, dwindsor@xxxxxxxxx, ebiederm@xxxxxxxxxxxx, elena.reshetova@xxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, hannes@xxxxxxxxxxx, henry.willard@xxxxxxxxxx, hpa@xxxxxxxxx, hughd@xxxxxxxxxx, imbrenda@xxxxxxxxxxxxxxxxxx, jack@xxxxxxx, jag.raman@xxxxxxxxxx, jane.chu@xxxxxxxxxx, jglisse@xxxxxxxxxx, jroedel@xxxxxxx, khalid@xxxxxxxxxxxxxx, khandual@xxxxxxxxxxxxxxxxxx, kirill.shutemov@xxxxxxxxxxxxxxx, kstewart@xxxxxxxxxxxxxxxxxxx, ktkhai@xxxxxxxxxxxxx, liam.merwick@xxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linuxram@xxxxxxxxxx, linux@xxxxxxxxxxxx, me@xxxxxxxx, mgorman@xxxxxxx, mgorman@xxxxxxxxxxxxxxxxxxx, mhocko@xxxxxxxx, mike.kravetz@xxxxxxxxxx, minchan@xxxxxxxxxx, mingo@xxxxxxxxxx
In-reply-to: <20180318.110857.1660518649370410007.davem@davemloft.net>
Organization: Oracle Corp
References: <cover.1519227112.git.khalid.aziz@oracle.com> <20180318.110857.1660518649370410007.davem@davemloft.net>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 03/18/2018 09:08 AM, David Miller wrote:

In uapi/asm/auxvec.h you conditionalize the ADI aux vectors on
CONFIG_SPARC64.

That's not correct, you should never control user facing definitions
based upon kernel configuration.

Also, both 32-bit and 64-bit applications running on ADI capable
machines want to compile against and use this informaiton.

So please remove these CPP checks.


Hi Dave,

That makes sense. I will send a patch to remove these.

Thanks,
Khalid

References:
- [PATCH v12 00/11] Application Data Integrity feature introduced by SPARC M7
  - From: Khalid Aziz
- Re: [PATCH v12 00/11] Application Data Integrity feature introduced by SPARC M7
  - From: David Miller

Prev by Date: Re: [PATCH] percpu: Allow to kill tasks doing pcpu_alloc() and waiting for pcpu_balance_workfn()
Next by Date: Re: get_user_pages returning 0 (was Re: kernel BUG at drivers/vhost/vhost.c:LINE!)
Previous by thread: Re: [PATCH v12 00/11] Application Data Integrity feature introduced by SPARC M7
Next by thread: [PATCH v3] mm: zsmalloc: Replace return type int with bool
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]