On Wed, Mar 14, 2018 at 01:56:31PM -0700, Andrew Morton wrote: > > + if (!is_atomic) { > > + if (gfp & __GFP_NOFAIL) > > + mutex_lock(&pcpu_alloc_mutex); > > + else if (mutex_lock_killable(&pcpu_alloc_mutex)) > > + return NULL; > > + } > > It would benefit from a comment explaining why we're doing this (it's > for the oom-killer). And, yeah, this would be great. Kirill, can you please send a patch to add a comment there? Thanks. -- tejun