On Fri, Mar 9, 2018 at 8:18 PM, Mark Rutland <mark.rutland@xxxxxxx> wrote: > On Fri, Mar 09, 2018 at 07:06:59PM +0100, Andrey Konovalov wrote: >> On Mon, Mar 5, 2018 at 3:54 PM, Mark Rutland <mark.rutland@xxxxxxx> wrote: >> >> Hi Mark! >> >> GCC before 5.0 doesn't support KASAN_INLINE, but AFAIU will fallback >> to outline instrumentation in this case. >> >> Latest Clang Release doesn't support KASAN_INLINE (although current >> trunk does) and falls back to outline instrumentation. >> >> So nothing should break, but people with newer compilers should get >> the benefits of using the inline instrumentation by default. > > Ah, ok. I had assumed that they were separate compiler options, and this > would result in a build failure. No worries, I'll check that GCC 4.9 works and add this info to the commit message. > > I have no strong feelings either way as to the default. I typically use > inline today unless I'm trying to debug particularly weird cases and > want to hack the shadow accesses. Great! > > Thanks, > Mark.
