Re: [RFC PATCH 14/14] khwasan: default the instrumentation mode to inline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 02, 2018 at 08:44:33PM +0100, Andrey Konovalov wrote:
> There are two reasons to use outline instrumentation:
> 1. Outline instrumentation reduces the size of the kernel text, and should
>    be used where this size matters.
> 2. Outline instrumentation is less invasive and can be used for debugging
>    for KASAN developers, when it's not clear whether some issue is caused
>    by KASAN or by something else.
> 
> For the rest cases inline instrumentation is preferrable, since it's
> faster.
> 
> This patch changes the default instrumentation mode to inline.
> ---
>  lib/Kconfig.kasan | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan
> index ab34e7d7d3a7..8ea6ae26b4a3 100644
> --- a/lib/Kconfig.kasan
> +++ b/lib/Kconfig.kasan
> @@ -70,7 +70,7 @@ config KASAN_EXTRA
>  choice
>  	prompt "Instrumentation type"
>  	depends on KASAN
> -	default KASAN_OUTLINE
> +	default KASAN_INLINE

Some compilers don't support KASAN_INLINE, but do support KASAN_OUTLINE.
IIRC that includes the latest clang release, but I could be wrong.

If that's the case, changing the default here does not seem ideal.

Thanks,
Mark.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux