On Wed, Feb 09, 2011 at 01:37:57PM -0800, Andrew Morton wrote: > On Wed, 9 Feb 2011 12:01:49 +0100 > Johannes Weiner <hannes@xxxxxxxxxxx> wrote: > > > Hi, > > > > this patch set converts the memcg charge and uncharge paths to operate > > on multiples of pages instead of bytes. It already was a good idea > > before, but with the merge of THP we made a real mess by specifying > > huge pages alternatingly in bytes or in number of regular pages. > > > > If I did not miss anything, this should leave only res_counter and > > user-visible stuff in bytes. The ABI probably won't change, so next > > up is converting res_counter to operate on page quantities. > > > > I worry that there will be unconverted code and we'll end up adding > bugs. > > A way to minimise the risk is to force compilation errors and warnings: > rename fields and functions, reorder function arguments. Did your > patches do this as much as they could have? I sent you fixes/replacements for 1/4 and 4/4. 2/4 and 3/4 adjusted the names of changed structure members already. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>