On Tue, Jan 16, 2018 at 02:46:16PM -0800, Andy Lutomirski wrote: > On Tue, Jan 16, 2018 at 8:36 AM, Joerg Roedel <joro@xxxxxxxxxx> wrote: > > From: Joerg Roedel <jroedel@xxxxxxx> > > > > Move it out of the X86_64 specific processor defines so > > that its visible for 32bit too. > > Hmm. This is okay, I guess, but any code that actually uses this > definition is inherently wrong, since 32-bit implies !PCID. Yes, I tried another approach first which just #ifdef'ed out the relevant parts in tlbflush.h which use this bit. But that seemed to be the wrong path, as there is more PCID code that is compiled in for 32 bit. So defining the bit for 32 bit seemed to be the cleaner solution for now. Joerg -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>