> On 01/31/2011 08:03 PM, Michel Lespinasse wrote: > > As Tao Ma noticed, change 5ecfda0 breaks blktrace. This is because > > blktrace mmaps a file with PROT_WRITE permissions but without PROT_READ, > > so my attempt to not unnecessarity break COW during mlock ended up > > causing mlock to fail with a permission problem. > > > > I am proposing to let mlock ignore vma protection in all cases except > > PROT_NONE. In particular, mlock should not fail for PROT_WRITE regions > > (as in the blktrace case, which broke at 5ecfda0) or for PROT_EXEC > > regions (which seem to me like they were always broken). > > > > Please review. I am proposing this as a candidate for 2.6.38 inclusion, > > because of the behavior change with blktrace. > > Acked-by: Rik van Riel <riel@xxxxxxxxxx> Reviewed-by :KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>