Of course, we should do that AFAP. Thanks for your comments :) -----Original Message----- From: owner-linux-mm@xxxxxxxxx [mailto:owner-linux-mm@xxxxxxxxx] On Behalf Of Michal Hocko Sent: Thursday, November 30, 2017 5:45 PM To: Wang, Kemi <kemi.wang@xxxxxxxxx> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>; Vlastimil Babka <vbabka@xxxxxxx>; Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>; Johannes Weiner <hannes@xxxxxxxxxxx>; Christopher Lameter <cl@xxxxxxxxx>; YASUAKI ISHIMATSU <yasu.isimatu@xxxxxxxxx>; Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>; Nikolay Borisov <nborisov@xxxxxxxx>; Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>; David Rientjes <rientjes@xxxxxxxxxx>; Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>; Dave <dave.hansen@xxxxxxxxxxxxxxx>; Kleen, Andi <andi.kleen@xxxxxxxxx>; Chen, Tim C <tim.c.chen@xxxxxxxxx>; Jesper Dangaard Brouer <brouer@xxxxxxxxxx>; Huang, Ying <ying.huang@xxxxxxxxx>; Lu, Aaron <aaron.lu@xxxxxxxxx>; Li, Aubrey <aubrey.li@xxxxxxxxx>; Linux MM <linux-mm@xxxxxxxxx>; Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx> Subject: Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement On Thu 30-11-17 17:32:08, kemi wrote: [...] > Your patch saves more code than mine because the node stats framework > is reused for numa stats. But it has a performance regression because > of the limitation of threshold size (125 at most, see > calculate_normal_threshold() in vmstat.c) in inc_node_state(). But this "regression" would be visible only on those workloads which really need to squeeze every single cycle out of the allocation hot path and those are supposed to disable the accounting altogether. Or is this visible on a wider variety of workloads. Do not get me wrong. If we want to make per-node stats more optimal, then by all means let's do that. But having 3 sets of counters is just way to much. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href
