Re: [PATCH v2 2/2] mm,vmscan: Mark register_shrinker() as __must_check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri 24-11-17 22:26:03, Tetsuo Handa wrote:
> Michal Hocko wrote:
> > As already pointed out, I do not think this is worth it. This function
> > is no different than many others which need error handling. The system
> > will work suboptimally when the shrinker is missing, no question about
> > that, but there is no immediate blow up otherwise. It is not all that
> > hard to find all those places and fix them up. We do not have hundreds
> > of them...
> 
> The system might blow up after two years of uptime. For enterprise systems
> which try to avoid reboots as much as possible, it is important to fix
> known bugs before deploying.

And how exactly __must_check help here? Seriously, if you really _care_
then make sure to fix those rather than add dubious code and keep
arguing over it.
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]
  Powered by Linux