On Wed, Nov 8, 2017 at 11:46 AM, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> wrote: > > + > static inline void pmd_populate_kernel(struct mm_struct *mm, > pmd_t *pmd, pte_t *pte) > { > + pteval_t pgtable_flags = mm_pgtable_flags(mm); Why is "pmd_populate_kernel()" using mm_pgtable_flags(mm)? It should just use _KERNPG_TABLE unconditionally, shouldn't it? Nothing to do with init_mm, it's populating a _kernel_ page table regardless, no? Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>