On Mon, Nov 06, 2017 at 11:43:54AM +0100, Michal Hocko wrote: > > Yes the comment is very much accurate. > > Which suggests that print_vma_addr might be problematic, right? > Shouldn't we do trylock on mmap_sem instead? Yes that's complete rubbish. trylock will get spurious failures to print when the lock is contended. The right solution is to not call this thing when you can't schedule, trying to divine the state in the print function is doomed to failure. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
