On 11/01/2017 04:18 AM, Andy Lutomirski wrote: >>> How about just adding a VM_WARN_ON_ONCE, then? >> What's wrong with xor? The function will continue to work this way even if >> CR4.PGE is disabled. > That's true. OTOH, since no one is actually proposing doing that, > there's an argument that people should get warned and therefore be > forced to think about it. What this patch does in the end is make sure that __native_flush_tlb_global_irq_disabled() works, no matter the intiial state of CR4.PGE, *and* it makes it WARN if it gets called in an unexpected initial state (CR4.PGE). That's the best of both worlds IMNHO. Makes people think, and does the right thing no matter what. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
