On Mon 02-10-17 10:20:37, Tahsin Erdogan wrote: > On Mon, Oct 2, 2017 at 12:56 AM, Michal Hocko <mhocko@xxxxxxxxxx> wrote: > > balance_dirty_pages_ratelimited doesn't really need mapping as well. All > > it needs is the inode and we already have it in callers. So would it > > make sense to refactor a bit further and make its argument an inode? > > My only concern is that, balance_dirty_pages_ratelimited() is an > exported function so changing its signature could potentially break > some drivers? All in-kernel drivers would have to be updated of course but exported symbols are not considered a stable API. It's not like we would want to change this for no good reason so the change should be done only if this makes sense in general. This is something for IO/FS guys to tell. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
